[MPlayer-dev-eng] [PATCH] configure fixes: x11 header dir always included, better CFLAGS for unknown compilers
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Dec 5 18:33:39 CET 2006
Hello,
please say what you think.
First part sets
CFLAGS="-O2 $_march $_mcpu $_pipe"
for non-intel, non-gnu compilers. None are supported so it might be
pointless, but on the other hand it helps with trying some things out.
Maybe a detection for -ffast-math, -fomit-frame-pointer, and -O4 would
be better, but also more complicated.
The other part adds _inc_x11 only to _inc_extra if X11 is enabled. I
intend to apply that port soon.
Hope you can forgive me that I was too lazy to split the patch just for review
;-)
Greetings,
Reimar Döffinger
-------------- next part --------------
Index: configure
===================================================================
--- configure (revision 21508)
+++ configure (working copy)
@@ -1560,6 +1560,8 @@
elif test -z "$CFLAGS" ; then
if test "$cc_vendor" = "intel" ; then
CFLAGS="-O2 $_march $_mcpu $_pipe -fomit-frame-pointer"
+ elif test "$cc_vendor" != "gnu" ; then
+ CFLAGS="-O2 $_march $_mcpu $_pipe"
else
CFLAGS="-O4 $_march $_mcpu $_pipe -ffast-math -fomit-frame-pointer"
fi
@@ -3815,8 +3817,6 @@
break
fi
done
- #FIXME: This is ugly as it can duplicate a -I parameter..
- _inc_extra="$_inc_extra $_inc_x11"
if test -z "$_inc_x11" ; then
_x11=no
_x11_headers="no"
@@ -3844,6 +3844,8 @@
done
fi
if test "$_x11" = yes ; then
+ #FIXME: This is ugly as it can duplicate a -I parameter..
+ _inc_extra="$_inc_extra $_inc_x11"
_def_x11='#define HAVE_X11 1'
_vosrc="$_vosrc x11_common.c vo_x11.c vo_xover.c"
_vomodules="x11 xover $_vomodules"
More information about the MPlayer-dev-eng
mailing list