[MPlayer-dev-eng] [PATCH] configure fixes: x11 header dir always included, better CFLAGS for unknown compilers

[Reimar Doeffinger]

Hello,
On Tue, Dec 05, 2006 at 10:12:39PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> On Tuesday, 05 December 2006 at 18:33, Reimar Döffinger wrote:
> > please say what you think.
> > First part sets
> > CFLAGS="-O2 $_march $_mcpu $_pipe"
> > for non-intel, non-gnu compilers. None are supported so it might be
> > pointless, but on the other hand it helps with trying some things out.
> 
> Just "-O2" is sufficient and doesn't break things. non-intel non-gnu compilers
> probably don't support -march/-mcpu/-mtune switches.

But IIRC configure tests if they are available, so they will not hurt
either. Correct me if I'm wrong.

> > Maybe a detection for -ffast-math, -fomit-frame-pointer, and -O4 would
> > be better, but also more complicated.
> 
> Hm. I'm tempted to try out ICC. Is there any non-intel non-gnu compiler
> that can compile mplayer?

I do not know any non-intel non-gnu one that would even support the
variable-length macros MPlayer needs :-( (I assume that Apple's compiler
counts as gnu compiler).
At least linux ICC does not support __attribute__((used)) correctly so
you can only compile with --target=generic-linux. You can enable the
win32 codecs though ;-)
Somebody on ffmpeg-devel claimed the windows ICC could compile ffmpeg
with MMX - maybe he was thinking of 8.x though, I only know that
libmpeg2 and mp3lib would not work with that, though mp3lib might be
fixed.

> > The other part adds _inc_x11 only to _inc_extra if X11 is enabled. I
> > intend to apply that port soon.
> 
> Sounds reasonable.

Will apply this evening.

Greetings,
Reimar D?ffinger