[MPlayer-dev-eng] [PATCH] fix vo fbdev in directcolor modes

[Rich Felker]

On Mon, Feb 13, 2006 at 02:02:58AM -0500, Alan Curry wrote:
> The colormap save and restore code in vo_fbdev is broken; the caller of
> FBIOGETCMAP must allocate space for the reds, greens, and blues as well as
> for the struct that points to them. This only affects fb drivers that work in
> directcolor mode instead of truecolor mode, like radeonfb. This patch makes
> vo_fbdev work for me with radeonfb, which it didn't before.

I've found that a better solution is to patch the kernel to provide
truecolor instead of directcolor. Too many programs mess up with
directcolor, and IMO the kernel's support for directcolor is
fundamentally broken since it overwrites the first few entries with
the console text palette. (i.e. either your text turns all black, or
the black parts of your images become the text palette colors..)

> The patch also fixes the same problem with fbdev2, and afterward fbdev2 works
> at least some of the time (it still has some other problems)

However, this patch should of course be applied, as long as it's
correct.

Rich