[MPlayer-dev-eng] [patch] doublefree and misalign in dec_audio.c

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Feb 13 18:30:05 CET 2006


Hi,
On Mon, Feb 13, 2006 at 12:45:01PM +0100, Luca Barbato wrote:
> 1 the af got freed on af_uninit so the other free is wrong.

But _that_ free is for the af_stream_t *, AFAICT af_uninit only frees
the af_instance_t * 's

> 2 the buffers aren't aligned, so some altivec/SIMD code may not behave
> correctly at random if is expecting aligned space.

Yes, that is fine with me, I'd say it should be applied.

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list