[MPlayer-dev-eng] [PATCH] ve_lavc cosmetics

[The Wanderer]

Rich Felker wrote:

> On Sun, Feb 12, 2006 at 06:47:35PM +0100, Diego Biurrun wrote:
> 
>>On Sun, Feb 12, 2006 at 06:35:57PM +0100, Michael Niedermayer wrote:
>>
>>>i do not agree with
>>>* x=y / x = y changes
>>
>>Why?  It's more readable IMO, especially if it is inconsistently used in
>>the file.
> 
> IMO which is more readable depends STRONGLY on the context. For
> instance:

<snip>

> if ((x=bar(y)) > 10)
> vs
> if ((x = bar (y)) > 10)
> 
> (same reasoning)

FTLIW, I would find

if ((x = bar(y)) > 10)

or, better still,

if( (x = bar(y)) > 10)

more readable than either of those - although none of them are
particularly readable, IMO.


Other than that, I agree with what you seem to be proposing as the "most 
readable" form in each example.

> The idea that whitespace should conform to a single 'coding style'
> rule is IMO very misguided. The purpose of whitespace is to break the
> logical units (logical in terms of how humans think about it, not how
> the machine things) up in a way that makes them easier to read. This
> depends on the semantics of the code, not the syntax.

<applauds>

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.