[MPlayer-dev-eng] [PATCH] include config.h before img_format.h
Ivan Kalvachev
ikalvachev at gmail.com
Thu Feb 16 10:35:26 CET 2006
2006/2/15, Alan Curry <pacman at theworld.com>:
> Diego Biurrun writes the following:
> >
> >On Thu, Feb 09, 2006 at 02:56:36PM -0500, Alan Curry wrote:
> [... on the subject of getting the wrong IMGFMT_* definitions because they
> depend on WORDS_BIGENDIAN, defined in config.h]
> >> If that's the way you're going to fix it, there are at least 2 other places
> >> that need the same fix. I found them by sticking a #error in the
> >> non-WORDS_BIGENDIAN section of img_format.h and recompiling everything. They
> >> were vf_bmovl.c and sub_cc.c - and those are just the ones that are
> >> compilable on my machine.
> >
> >Send a patch..
>
> OK, I tried to find more instances of this problem, and it looks like those
> are the only 2. sub_cc.c includes img_format.h indirectly via video_out.h,
> and doesn't appear to actually use the IMGFMT_* constants, so it might not
> really be necessary to get them defined correctly. But what harm can it do?
Sorry for the (unnecessary ) delay.
I'll commit it but config.h would be before all other 'local' headers.
For example in spu_cc.c it must be before subtitles.h as subtitle.h
have HAVE_ENCA, USE_FIBIDI conditions (not that this will break build
but...)
More information about the MPlayer-dev-eng
mailing list