[MPlayer-dev-eng] [PATCH 4/11] MPlayer <-> GeeXboX patches port : VCD-DVD-CDDA slave playback

[Rich Felker]

On Sat, Feb 25, 2006 at 12:07:35PM +0100, Benjamin Zores wrote:
> On Fri, 24 Feb 2006 12:03:44 -0500
> Rich Felker <dalias at aerifal.cx> wrote:
> 
> > On Fri, Feb 24, 2006 at 04:13:33PM +0100, Benjamin Zores wrote:
> > > 
> > > This patch adds new MPlayer internal commands to allow playback of VCD/DVD/CDDA.
> > > It then can be called through slave mode.
> > > 
> > > Ben
> > > 
> > > -- 
> > > "My life, and by extension everyone else's is meaningless."
> > > Bender, Futurama
> > 
> > > Index: MPlayer-20051213/input/input.c
> > > ===================================================================
> > > --- MPlayer-20051213.orig/input/input.c	2006-02-23 10:50:42.000000000 +0100
> > > +++ MPlayer-20051213/input/input.c	2006-02-23 10:51:07.000000000 +0100
> > > @@ -104,6 +104,15 @@
> > >  #ifdef HAS_DVBIN_SUPPORT
> > >    { MP_CMD_DVB_SET_CHANNEL, "dvb_set_channel", 2, { {MP_CMD_ARG_INT,{0}}, {MP_CMD_ARG_INT,{0}}, {-1,{0}}}},
> > >  #endif
> > > +#ifdef HAVE_VCD
> > > +  { MP_CMD_VCD_PLAY, "play_vcd", 0, { {MP_CMD_ARG_STRING, {0}}, {-1,{0}} } },
> > > +#endif
> > > +#ifdef USE_DVDREAD
> > > +  { MP_CMD_DVD_PLAY, "play_dvd", 0, { {MP_CMD_ARG_STRING, {0}}, {-1,{0}} } },
> > > +#endif
> > > +#ifdef HAVE_CDDA
> > > +  { MP_CMD_CDDA_PLAY, "play_cdda", 0, { {MP_CMD_ARG_STRING, {0}}, {-1,{0}} } },
> > > +#endif
> > 
> > Is there a reason "loadfile dvd://" fails?
> > If not, this patch is rejected.
> 
> The patch also adds the complete list of tracks (CDDA) and chapters (VCD/DVD) to playtree
> so that user can go to the one of its choice through libmenu after the disc has been opened.

Hmm, this sounds useful, but naming the commands something like
"load_*_tracks" would probably make more sense, and be more consistent
with loadfile. The way it was, I wouldn't have guessed what the
commands do without fully RTFS'ing (which I obviously didn't do :).

Rich