[MPlayer-dev-eng] [PATCH] printf warning fixes (REPOST)

[Dominik 'Rathann' Mierzejewski]

On Thursday, 12 January 2006 at 12:33, Diego Biurrun wrote:
> On Wed, Jan 11, 2006 at 11:01:34AM +0100, Dominik 'Rathann' Mierzejewski wrote:
> > On Tuesday, 10 January 2006 at 14:47, Reimar Doeffinger wrote:
> > > > ve_vfw.c includes <wine/vfw.h>
> > > > They are long:
> > > > 
> > > > loader/wine/vfw.h
> > > > typedef struct __attribute__((__packed__))
> > > > {
> > > >     long        biSize;
> > > >     long        biWidth;
> > > >     long        biHeight;
> > > >     short       biPlanes;
> > > >     short       biBitCount;
> > > >     long        biCompression;
> > > >     long        biSizeImage;
> > > >     long        biXPelsPerMeter;
> > > >     long        biYPelsPerMeter;
> > > >     long        biClrUsed;
> > > >     long        biClrImportant;
> > > > } BITMAPINFOHEADER, *PBITMAPINFOHEADER, *LPBITMAPINFOHEADER;
> > > 
> > > This is absolutely wrong, it will have different sizes on 32 and 64 bit
> > > architectures, someone please fix it and have a look out for more of
> > > this kind of bugs.
> > 
> > That's why I insisted on patching the loader to use intXX_t types when
> > this first came up, but you guys overrode me and this is the result.
> > 
> > I guess I'll just dig up my old patch and adapt it once again.
> 
> Until then, will you commit the non-controversial part of this?  Reimar
> agreed to it AFAIR.

Committed.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"