[MPlayer-dev-eng] [PATCH] Profile support for MEncoder / MPlayer - Take 3

[Jindrich Makovicka]

Guillaume POIRIER wrote:
> A few comments while I'm compiling your patch:
> 
>> diff -Naur orig/configure main/configure
>> --- orig/configure    2006-01-10 22:59:15.000000000 +0100
>> +++ main/configure    2006-01-08 20:16:01.000000000 +0100
>> @@ -7941,6 +7941,9 @@
>>  #define X11_FULLSCREEN 1
>>  #endif
>>  
>> +/* main language selected - used by profiles.c */
>> +#define MAIN_LANGUAGE    "$_language"
>> +
>>  #endif /* MPLAYER_CONFIG_H */
>>  EOF
> 
> 
> Is that smth necessary? Can't the current "internationnalization" system
> be used here? Just as much as one may want to have console messages
> translated in his native language, it makes sense that the language used
> picked up by profiles.c is the same, don't you think?
> 
> It must be defined somewhere in configure.

AFAICS, this is exactly what the code does. It picks up the description
in the native language and falls back to English if the description
isn't found.

The manual section contains some spelling errors (at least "sintax" and
 "english"), so it should be corrected before committing.

-- 
Jindrich Makovicka