[MPlayer-dev-eng] Re: [PATCH] Profiles support for MEncoder - Upgrade

Diego Biurrun diego at biurrun.de
Mon Jan 23 23:32:45 CET 2006


On Mon, Jan 23, 2006 at 05:55:28PM +0100, Alban Bedel wrote:
> On Mon, 23 Jan 2006 15:38:54 +0100
> Danny - liste <pi at digitalfantasy.it> wrote:
> 
> > Alban Bedel wrote:
> > 
> >     For the fact to have another parser I agree with you: it's better to 
> > have only one parser (and I'm talking also about the suboptions parser).
> 
> Well i don't known much about the suboptions parser, beside that i suspect
> it duplicate a lot of code alredy in the "normal" option parsers.
> 
> >     Maybe it's time to make a libmpparse with, documented, the various 
> > function you can use ?
> 
> In a way there alredy is:
> * m_option.[ch] m_struct.[ch]
>     Low level data handeling: convert from/to string, copy, etc
> * m_config.[ch]
>     High level configuration: take care of saving/restoring configurations
>     for the per file/group options, etc
> * parser-*.[ch]
>     Parse the config file/command line: check/set the options and build the
>     playlist.
> 
> But their is no docs (beside some comments in the sources) and the API
> is not really trivial :(

Could you maybe start documenting this?  A few doxygen comments would do
wonders.  Nobody fully understands the parsers except for you...

Diego




More information about the MPlayer-dev-eng mailing list