[MPlayer-dev-eng] [PATCH] dvdnav

[Dominik 'Rathann' Mierzejewski]

Hi,

On Saturday, 21 January 2006 at 15:45, Ötvös Attila wrote:
> 2006. január 14. 04.49 dátummal Dominik 'Rathann' Mierzejewski ezt írta:
> > First, let me congratulate you on achieving something many people thought
> > impossible with current MPlayer design.
> >
> > Second, your patch works for me just fine, I'm really amazed.
> >
> > Third, there's a small problem: if I apply the patch, but don't specify
> > --enable-dvdnav for ./configure, MPlayer build fails with:
> > mplayer.c:2249: error: ‘dvdnav_go_spu’ undeclared (first use in this
> > function)
> 
> I am revised it.

Tested again, this time with GiTS R0 Polish re-release and noticed the
following problems:

In GUI, I'm constantly getting "DVDNAV stream seek error:0" after every
title switch.

>From command line, mouse navigation doesn't work at all: No bind found for
key 'MOUSE_BTN0'

Aspect ration of the main title/movie is not correct. Menu is 4:3
but movie is 16:9 and it doesn't get switched.

In the preferences screen, the settings texts are duplicated below. My guess
is that these are their "inactive" versions. It doesn't prevent preferences
from working, but is a bit confusing.

Other than that, it seems mostly fine.

> > Please bear with us a little more and fix this. It probably involves
> > putting #ifdef DVDNAV or something similar around the new code and adding
> > appropriate code to ./configure.
> 
> In this dvdnav patch the waiting time length at still frame event was 
> implemented.

After applying the patch and NOT using --enable-dvdnav, MPlayer still
fails to compile, so this is still not fixed.

Good work so far. Amazing, really, but please bear with us a bit longer
and try to fix the above.

> I am sorry, my ISP lost my web pages because I created other web pages:
> 
> http://dcxx.fw.hu
> 
> (I am sorry to say that my English knowledge isn't good.)

Please, stop apologizing, it's good enough.

Best regards,
R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"