[MPlayer-dev-eng] [PATCH 1/5] ao_alsa: remove mmap support

[Dominik 'Rathann' Mierzejewski]

On Monday, 30 January 2006 at 09:14, Clemens Ladisch wrote:
> This patch removes mmap support because it doesn't have any benefit.
> 
> Directly accessing the sample buffer makes sense only when the samples
> can be constructed in-place.  When the samples are just copied from
> another buffer (as is the case with libao2 drivers), the code to copy
> those samples is just a reimplementation of snd_pcm_writei(), so we
> could as well use that function. 
> 
> Besides, the current mmap code does not work except in the most simple
> cases: it claims to support non-interleaved and complex sample formats,
> but treats them the same as interleaved formats and writes to the wrong
> memory location.

I'm strongly against removing mmap support. On at least one system it is
the only way to get clear sound out of my crappy on-board audio.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and oppression
to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan