[MPlayer-dev-eng] [PATCH] Radio support for MPlayer

[Diego Biurrun]

On Fri, Jul 14, 2006 at 12:33:36AM +0700, Vladimir Voroshilov wrote:
> Reimar Doeffinger wrote: 
> > On Mon, Jul 10, 2006 at 01:12:00AM +0700, Vladimir Voroshilov wrote:
> > 
> > > +ifeq ($(findstring yes,$(TV)$(RADIO_CAPTURE)),yes)
> > 
> > I find that really ugly, and don't we use
> > ifneq ($(TV)$(RADIO_CAPTURE),)
> > for the same effect in other places?
> ifneq does not have SAME effect. By default RADIO_CAPTURE=no (not empty. you can also set  
> --disable-tv-v4l --disable-tv-v4l and check the behaviour of ifneq ($(TV_V4L)$(TV_V4L2),) - 
> make will compile alsa1x.c when it souldnt due to configure options), 
> so "ifneq ($(TV)$(RADIO_CAPTURE),)" will be true in this case.
> "ifeq ($(findstring yes,$(TV)$(RADIO_CAPTURE)),yes)" will be true if and only if at least one
> of given variables is equals to 'yes'.

Hmmmmmm, yes, that's a problem that we need to look into :-/

Diego