[MPlayer-dev-eng] [PATCH] remove opendivx/divx4 support

[Diego Biurrun]

On Fri, Jul 14, 2006 at 10:41:34PM +0200, Michael Niedermayer wrote:
> 
> On Fri, Jul 14, 2006 at 08:20:17PM +0200, Roberto Togni wrote:
> > On Fri, 14 Jul 2006 19:11:18 +0200
> > Diego Biurrun <diego at biurrun.de> wrote:
> > 
> > > > I agree.  I'll remove this by the weekend.
> > > 
> > > The weekend arrived early ;)  Committed ...
> > > 
> > 
> > As i already said in the other tread, i was against it and i'm still
> > against it.
> > The code not breaking anything, so there was not urgent need to remove
> > it; even less to remove it before the deadline you announced.
> 
> iam also not completely happy with the removial, but then again iam also
> not happy with linking GPL to non GPL code

IMO support for combining MPlayer with non-free code should be an
exception, not the norm, and we should strive to eliminate this where
it no longer serves a good purpose.

> in the past being able to try many different decoders was usefull to
> debug and improve lavc, now that lavcs mpeg4 decoder is pretty much bugfree
> the loss of -vd divx4 will probably have little if any effect but still

I don't think anybody uses this code anymore.  For debugging and comparison
purposes we have XviD and some binary codecs, that's more than enough.

> i agree with roberto here that the removial was too quick without giving
> people a chance to comment

I agree myself now, see my reply to Roberto.

Diego