[MPlayer-dev-eng] [PATCH] 2 lines doing nothing in update_osd_msg() in mplayer.c ?

[Paul-Francois Fontigny]

On Thu, 2006-07-27 at 19:58 +0300, Uoti Urpala wrote:
> On Thu, 2006-07-27 at 18:17 +0200, Paul-Francois Fontigny wrote:
> > last_pts and pts are "very" local.
> > Eventually the second line is just wrong! What's the point?
> 
> Did you not understand what the "static" part of the last_pts
> declaration means? The lines certainly do something: they prevent the
> whole-second pts shown in the osd from going back by one second from the
> previous value. Now why such functionality was added I'm not sure -
> maybe it was a workaround for some bug causing pts to jump around. I
> think removing the lines should be OK - if something makes the time jump
> around there should be a better fix for it.

I understand the static for last_pts.
But it is very unlikely that from one call to the function to the next
the time difference will be one second backward. Even with local pts
casted to int (sh_video->pts  is a float - or is it a double?)
Why will this be a special case in this local part of the function?

Paul-Francois Fontigny