[MPlayer-dev-eng] [PATCH] restored dvdnav:// stream layer

Nico Sabbi nsabbi at email.it
Mon Jun 12 15:05:25 CEST 2006


Ivan Kalvachev wrote:
>
> Just by looking the patch only.
>
> +  if(1)    //from vlc: if not used dvdnav from cvs will fail
> +  {
> +    int len, event;
> +    char buf[2048];
>
> I don't see buf[] been used in the scope of its definition.
> (unless dvdnav_get_next_block is macros using buf[] )

it is used:

+  if(1)        //from vlc: if not used dvdnav from cvs will fail
+  {
+    int len, event;
+    char buf[2048];
+
+    dvdnav_get_next_block(dvdnav_priv->dvdnav,buf,&event,&len);
+  }
                                                                               
^^^^


>
> And is there any particular reason to replace printf with fprintf, and
> not with mp_msg ?
> _______________________________________________
right.  I'll fix it tonight
 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Studiare è facile e divertente con le tecniche di Apprendimento 
* Creativo, in offerta speciale a soli € 49 fino al 31 Agosto!
* 
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=5298&d=12-6



More information about the MPlayer-dev-eng mailing list