[MPlayer-dev-eng] [PATCH] Remove duplicated CPU detection in libmpeg2

[Michael Niedermayer]

Hi

On Fri, Jun 16, 2006 at 11:36:21AM +0200, Guillaume POIRIER wrote:
> Hi Michael,
> 
> On 6/15/06, Michael Niedermayer <michaelni at gmx.at> wrote:
> >Hi
> >
> >On Thu, Jun 15, 2006 at 05:54:48PM +0800, jserv at linux2.cc.ntu.edu.tw wrote:
> >> On Thu, Jun 15, 2006 at 05:49:49PM +0800, jserv at linux2.cc.ntu.edu.tw 
> >wrote:
> >> > On Thu, Jun 15, 2006 at 11:29:40AM +0200, Michael Niedermayer wrote:
> >> > > Hi
> >> > >
> >> > > On Thu, Jun 15, 2006 at 02:35:32PM +0800, jserv at linux2.cc.ntu.edu.tw 
> >wrote:
> >> > > [...]
> >> > >
> >> > > 3DNOW is ignored by this patch
> >> >
> >> > hi Michael,
> >> >
> >> >   Thanks for remanding me of 3DNow! detection, and I have updated my
> >> > patch in attachment.
> >>
> >> Hello list,
> >>
> >> I am sorry that I sent the wrong attachment, and this one is correct
> >> though.
> >
> >and its still not correct for MMX2 + 3dnow cpus, or SSE2 + 3dnow
> >and the code is getting more and more messy for a trivial
> >
> >if(mmx)   flags |= MMX;
> >if(3dnow) flags |= 3DNOW;
> >...
> >return flags
> >
> >and please no 20 #ifdefs around each if()
> 
> Is the attached patch what you wanted?

yes, exactly

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is