[MPlayer-dev-eng] [PATCH] DivX6 support

[Reimar Döffinger]

Hi,
On Tue, Jun 20, 2006 at 08:57:10PM +0200, Roberto Togni wrote:
> As long as the code does not bloat others part of the player (vd_,
> ve_, and such are surely in this class) I see no reason to remove
> support for external libraries, somebody may find it useful.

Ack, though I have a not-too-good feeling about code in MPlayer of which
the explicity and only use is to link against/use non-GPL code. This in my
view is a bit different with the dshow binary codec stuff, since it
supports a general API (probably not for the mov and rm stuff though).

> Same for adding support for new ones: I won't spend my time on them,
> but as long as there is a working patch and some developer is willing
> to apply and mantain it that's ok.

Well, that was basically why I asked why we would want it.
My conclusion is I won't spend time reviewing this.
As usual I won't shout against applying after proper review and having
someone to maintain if ever neccessary.

> We can remove them when they became broken because of other changes and
> nobody cares to fix them.

Well, in theory part of maintenance is testing/searching for bugs. I'm
not sure this is done with some of these parts, which gives my a rather
bad feelings, esp. for security implications. Though whoever thinks
MPlayer (or any other video player IMHO) will ever be anything than
one of the more easily exploited apps is a fool.

Greetings,
Reimar Döffinger