[MPlayer-dev-eng] [PATCH] ggi osd support added
Reynaldo H. Verdejo Pinochet
reynaldo at opendot.cl
Fri Jun 30 10:14:46 CEST 2006
On Fri, Jun 30, 2006 at 03:40:33AM -0400, spdepagn at ncsu.edu wrote:
> Hi, I have added support for the osd to the ggi output driver. I am
> wondering why the osd is implemented so each output driver must implement
> it.
>
> I do not know much about the inner-workings of mplayer, but to me this
> seems to only make it more difficult to write output drivers.
>
> Instead, why not do the alpha blending for the osd before ever calling the
> functions within the output driver? This way the output plugin will only
> ever know about the fully blended data, it is also potentially more
> efficient. If this seems reasonable I would be willing to make the needed
> changes, otherwise this patch will allow ggi to use the osd.
>
> I have applied it like this:
> ...mplayer $ patch -p1 < mplayer_ggi_osd.patch
>
> Thanks,
> Sean D'Epagnier
At a first glance you have a few unneded cosmetic changes here,
besides that, try to make your patches from the root level of the code
base.
Best ragards and thanks for your work.
Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060630/6ccbec7e/attachment.pgp>
More information about the MPlayer-dev-eng
mailing list