[MPlayer-dev-eng] [BUG?][PATCH] af_equalizer too quiet

[Reynaldo H. Verdejo Pinochet]

On Fri, Mar 10, 2006 at 08:16:03PM -0300, Reynaldo H. Verdejo Pinochet wrote:
> On Tue, Nov 22, 2005 at 08:08:13PM -0800, Corey Hickey wrote:
> > I noticed that mplayer -af equalizer reduces the volume significantly.
> > Consider this command:
> > 
> > $ mplayer file.mp3 -af equalizer
> > 
> > (this corresponds to -af equalizer=0:0:0:0:0:0:0:0:0:0)
> > 
> > Since the suboptions accept a range from -12 to 12 and 0 is the default,
> > I would expect 0 to be the neutral position and to have no effect on the
> > audio. Instead, the volume is reduced by a factor of 40 by line 193 of
> > af_equalizer.c:
> > 
> > *out=yt/(4.0*10.0);
> > 
> > Is that a bug? If so, the attached patch fixes it.
> > 
> > -Corey
> 
> Ok, new patch made with the help of Benjamin Larsson. should take
> care of avoiding the atenuation of unamplified signals and clipping 
> when filtered output exceds dinamic range. please test, I will
> apply this patch soon if no one complains.
> 
> Best regards
> 
>    Reynaldo

Commited

  Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060311/924807fe/attachment.pgp>