[MPlayer-dev-eng] [PATCH] disable filters that depend on dsputil.h

[Nico Sabbi]

Ivan Kalvachev wrote:

>2006/3/14, Nico Sabbi <nicola_sabbi at fastwebnet.it>:
>  
>
>>Hi,
>>last months we added dsputil.h to the install target of libavcodec;
>>it was a mistake because that file is not supposed to be used outside of
>>libavcodec.
>>
>>This patch disables the inclusion of filters that depend on that header
>>when libavcodec
>>is not imported in main/; if applied I'll post a patch to ffmpeg-devel
>>to restore the previous
>>behaviour (not install dsputil.h).
>>
>>Please, review.
>>    
>>
>
>I'm afraid this could be considered feature removal.
>  
>
it's not, it's the correction of a mistake: as I wrote Michael prefers 
to keep that file
private to libavcodec

>The reason (interface purity) doesn't justify the result.
>  
>

rather than interface purity I consider it interface presence :)

>However I am not against conditional compilation of these filters.
>This includes ./configure detection of dsputil.h presence and check
>for called functions availability.
>
>  
>

static libavcodec involves the presence of dsputil.h


    Nico