[MPlayer-dev-eng] [PATCH] printf -> mp_msg

[Reynaldo H. Verdejo Pinochet]

On Sun, Mar 19, 2006 at 07:24:37PM +0100, Ötvös Attila wrote:
> Hi All!
> 
> Files:
>
> [cut]
>
> Best regards!
> Attila


* Not really sure but:

- MSGTR_MPLIBAO2_UnkkownSupportedOSSFromat "Unknown/not supported OSS
format: %x\n"
+ MSGTR_MPLIBAO2_UnkkownSupportedOSSFromat "Unknown/Not supported OSS
format: %x\n"

* Just to stay consistent with:
MSGTR_MemAllocFailed "Memory allocation failed\n":

- MSGTR_LIBMENU_MallocError "malloc error: %s"
+ MSGTR_LIBMENU_MAllocError "Memory allocation error: %s"

* Check phrasing on this ones:

MSGTR_LIBMENU_MenuTxtNeedATxtFileName "Menu txt need a txt file name
(param file)\n" (sounds weird)

MSGTR_LIBMENU_MenuTxtCantOpen "Menu txt can't open: %s\n" (sounds weird)

MSGTR_LIBMENU_WarningTooLongLineSplitting "Warning too long
line, splitting it\n" (Warning, string too long, splitting it ?)

MSGTR_LIBVO_Dxr3UseUnknownNormSuppliedCurrentNorm "Unknown norm
supplied. Use current norm" (Using ?)

* The '[(all caps?)string]' form is used everywhere when messages are preceeded by 
code module identifiers (?) please check all ocurrences of variants
([string:] / string: / .. ) and adjust to fit common use.

as in:

MSGTR_LIBVO_MgaUsingBuffers "[mga] Using %d buffers.\n"
MSGTR_LIBVO_VomgaCouldntOpen "vo_mga: Couldn't open %s\n"
MSGTR_LIBVO_Display3dfxInitialized "(display) 3dfx initialized %p\n"

there are several

if you cant make it so your patch stays consistent in form and phrasing
with the master help_mp-en please do your best to at last check it is
consistent within itself.

* Check for correct use of caps in the first letter of most messages.

* Check for period (.) at the end of 'complete sentence' messages.

Im not a native eng speaker neither, so i know the feeling ;) if you
need some help just check and repost.

Best regards and thanks again for your work.

  Reynaldo
  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060319/1db28198/attachment.pgp>