[MPlayer-dev-eng] [PATCH] ppc fix for realvideo in mkv

Moritz Bunkus moritz at bunkus.org
Wed Mar 22 12:52:16 CET 2006


Hey,

(this message might become a dupe if a moderator approves my previous
one ;))

Thanks for fixing this bug. The patch has two problems that I'd like you
to fix before I apply it:

1. variable declaration after instructions (trivial to fix) and

2. possible non-aligned memory access as "a" might point to non-aligned
addresses

The solution for 2 would be something like
  put_uint32_be(a + i, get_uint32_le(a + i));
which doesn't try to read a complete uint32_t at once.

Mosu

-- 
If Darl McBride was in charge, he'd probably make marriage
unconstitutional too, since clearly it de-emphasizes the commercial
nature of normal human interaction, and probably is a major impediment
to the commercial growth of prostitution. - Linus Torvalds

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060322/046ae331/attachment.pgp>


More information about the MPlayer-dev-eng mailing list