[MPlayer-dev-eng] [PATCH] support for external VIDIX

Diego Biurrun diego at biurrun.de
Wed Mar 29 00:21:03 CEST 2006


On Tue, Mar 28, 2006 at 09:10:44PM +0200, Oded Shimon wrote:
> On Tue, Mar 28, 2006 at 08:53:49PM +0200, Nico Sabbi wrote:
> > Diego Biurrun wrote:
> > > > +if test "$_vidix_internal" = yes || test "$_vidix_external" = yes ; then
> > >
> > >"test A -o B" is simpler and faster.
> 
> And less portable and less readable?....
> 
> I recall there being a discussion about this.... IIRC '&&' and '||' won...

Matter of taste.  I honestly don't remember the outcome.  We do seem to
have more ||/&& than -o/-a in configure, though.

Nico, maybe change back to using ||, I don't much care.  Anyway, commit,
the patch looks good :)

Diego




More information about the MPlayer-dev-eng mailing list