[MPlayer-dev-eng] Re: [PATCH] Allow aspect change in TS and DVB

[Nico Sabbi]

Carl Eugen Hoyos wrote:

>
>...
>Starting playback...
>Detected unknown aspect_ratio_information in mpeg sequence header.
>Please report the aspect value (0) along with the movie type
>(VGA,PAL,NTSC,SECAM) and the movie resolution (720x576,352x240,480x480,...) to
>the MPlayer developers, so that we can add support for it!
>Assuming 1:1 aspect for now.
>...
>
>That's because you disabled property reading for AVI MPEG1/2 files on January
>12th (it always worked for me as long as no aspect change was expected).
>  
>

it was done in a very very ugly and hackish way that also made mplayer 
crash in some
cases

>So I would suggest once again to test the demuxer type: Does it make sense to
>check for aspect ration change in another medium than TS/DVB?
>  
>

yes, ever heard of dvd?

>Thanks to Reimars patch for vo_xv, aspect ratio change now also works for
>fullscreen;-)
>
>Any chance to get this one committed? I think it's very useful to people using
>mplayer to watch DVB.
>
>  
>

not in this form. The time for hackish tricks to make mplayer "just work 
in some way"
is hopefully over (because it leads to nasty problems that are hard to 
track and fix).
Work is ongoing to fix many if the worst parts of mplayer.

As for the A/R function Ivan and I think that video.c is not really the 
best place for it;
maybe mpeg_hdr.c.
Opinions?

>+               if (sh->ds->demuxer->file_format == DEMUXER_TYPE_MPEG_TS)
>+                       fill_mpeg12_aspect_info(&sh->aspect);
>                if(!mpcodecs_config_vo(sh,
>  
>

very bad, see above.