[MPlayer-dev-eng] [BUG] libavcodec issue with bframes

[Roberto Togni]

On Tue, 9 May 2006 11:06:30 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> Hi
> 
> On Tue, May 09, 2006 at 12:00:30AM +0200, Roberto Togni wrote:
> > On Mon, 8 May 2006 19:35:37 +0200
> > Michael Niedermayer <michaelni at gmx.at> wrote:
> > 
> > > Hi
> > [...]
> > > 
> > > for the release iam fine with MP_NOPTS_VALUE, for cvs after the release iam
> > > against it, when someone will need the timestamps in their encoder, filter or
> > > muxer they almost certainly wont dare or even know what to change
> > > 
> > [...]
> > 
> > Can anybody submit (or commit) a patch for this nopts change? I have no
> > clue about mencoder and this is one of the major things holding back
> > the release.
> > 
> > Else please tell me if i should to apply the patch from this thread
> > or the one posted by Nico on Apr 23 ([MPlayer-dev-eng] [BUG] [PATCH]
> > encoding with lavc and b-frames is partially broken).
> 
> something like:
> @@ -1316,7 +1316,7 @@
>  default:
>      // decode_video will callback down to ve_*.c encoders, through the video filters
>      blit_frame=decode_video(sh_video,frame_data.start,frame_data.in_size,
> -      skip_flag>0 && (!sh_video->vfilter || ((vf_instance_t *)sh_video->vfilter)->control(sh_video->vfilter, VFCTRL_SKIP_NEXT_FRAME, 0) != CONTROL_TRUE), mux_v->timer);
> +      skip_flag>0 && (!sh_video->vfilter || ((vf_instance_t *)sh_video->vfilter)->control(sh_video->vfilter, VFCTRL_SKIP_NEXT_FRAME, 0) != CONTROL_TRUE), MP_NOPTS_VALUE);
> 
>      if (sh_video->vf_inited < 0) mencoder_exit(1, NULL);
> 
> might work, warning this is not a real patch, just hand edited ...
> 

Thanks, applied. I'll revert it after pre8.

Ciao,
 Roberto