[MPlayer-dev-eng] Gui #include correction

[Dominik 'Rathann' Mierzejewski]

On Saturday, 13 May 2006 at 22:02, Adam Tlałka wrote:
> On Sat, May 13, 2006 at 07:21:03PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > On Saturday, 13 May 2006 at 18:08, Diego Biurrun wrote:
> > > On Sat, May 13, 2006 at 04:59:32PM +0200, Adam Tla?ka wrote:
> > > > On Sat, May 13, 2006 at 03:45:52PM +0200, Diego Biurrun wrote:
> > > > > On Sat, May 13, 2006 at 10:05:15AM +0200, Adam Tla?ka wrote:
> > > > > > 
> > > > > > since gtk code is located in Gui/mplayer/gtk now include paths leading
> > > > > > to main dir should be corrected. Patch attached.
> > > > > 
> > > > > This is not necessary since we have -I.. in the CFLAGS.  Patch rejected.
> > > > 
> > > > Really? Funny ;), I have current cvs version and it just not compile with gui
> > > > enabled after configure. It reports about undefined messages while
> > > > parsing gui code.
> > > > So what is wrong here?
> > > 
> > > This is a detail you should mention from the start.  It works without
> > > problems for me and I haven't heard any reports about the GUI not
> > > compiling before.  I don't believe the problem is in the build system.
> > 
> 
> OK I've checked it again:
> 
> $ cvs update -d .

Try cvs update -dPA

> $ ../config.sh
> $ make
> .
> .
> .
> cc -c -I../libvo -I../../libvo  -fno-PIC -O4 -march=pentium4
> -mtune=pentium4 -pipe -ffast-math -fomit-frame-pointer -D_REENTRANT
> -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -I. -I.. -I../loader -I./wm
> -I./skin -I/usr/include/freetype2 -I/usr/include/gtk-2.0
> -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo
> -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include     -DDEBUG  -o mplayer/gtk/menu.o
> mplayer/gtk/menu.c
> mplayer/gtk/menu.c: In function `create_PopUpMenu':
> mplayer/gtk/menu.c:403: error: `MSGTR_MENU_AboutMPlayer' undeclared
> (first use in this function)
> mplayer/gtk/menu.c:403: error: (Each undeclared identifier is reported
> only oncemplayer/gtk/menu.c:403: error: for each function it appears
> in.)
> mplayer/gtk/menu.c:403: error: parse error before string constant
> mplayer/gtk/menu.c:405: error: `MSGTR_MENU_Open' undeclared (first use
> in this function)
> etc.
> 
> config.sh:
> # !/bin/bash

> ./configure --enable-menu --enable-gui --enable-largefiles
--disable-inet6 --disable-arts --disable-esd --disable-nas --disable-gl
--disable-vesa --disable-svga --disable-sdl --disable-fbdev $*

> My distro is Ubuntu stable, gcc 3.4.5, make 3.80.
> As you can see there is -I.. in compilation command.
> Maybe my compiler treats #include "../something.h" relatively to the
> source file dir and not uses -I paths in case of path specified in
> #include (relative or absolute). So maybe there should be -I../../..
> in compilation command and just #include "something.h" in source?

My guess is your cvs checkout is somehow broken. Works fine here.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan