[MPlayer-dev-eng] [PATCH] dvdnav - partial REVIEW

[Diego Biurrun]

On Thu, May 18, 2006 at 11:11:22PM +0200, Ötvös Attila wrote:
> 2006. május 6. 18.59 dátummal Nico Sabbi ezt írta:
> 
> > First of all: you added a directory with a scary name -libmpdvdnav-,
> > that contains a modified version of libdvdnav. IMO this not
> > acceptable; I wish that you could make your code work with the
> > standard libdvdnav (importing still another projtect in mplayer is a
> > serious problem: the sources tarball would grow even more and no one
> > would fix/maintain it).
> 
> I think that your condition with libdvdnav killes the dvdnav patch that's why
> if it can't use new libdvdnav functions then the dvd menu can't work a lot of
> disks. I can promise you that I send my modify to libdvdnav developers:
> 
> I wrote 13 Feb 21:51 (libdvdnav devel):
> "I guess let's wait that the patch will be final. It is probable that we will 
> be able to drop out more my functions."
> http://blog.gmane.org/gmane.comp.video.libdvdnav.devel/month=20060201

Nico has a point, it would be best if you could cooperate with the
upstream libdvdnav developers.  Adding libmpdvdnav is a possibility as
well if that does not work out.

> > Second: you added a second dvdnav stream. This is wrong, because there's
> > no reason to keep the old one lying around unused. You should patch the
> > old one instead.
> 
> I think so big parts of the old dvdnav stream can drop therefore my work is
> other conception. I think so the name of the stream_dvdnav is much better
> than the dvdnav_stream (stream_dvd, stream_file, etc.)
> 
> > Consequently all the blocks of code #ifdef-ed MPDVDNAV should not exist
> > anymore.
> 
> I think so #ifdef-ed MPDVDNAV can be removed if dvdnav patch replaces
> old functions and no expansion it. I would like to know if remove is in patch. 

Would it help if we ripped out the remnants of the old dvdnav support?
They are commented out in configure anyway and the code is dead.  You
would then have a clean base to build upon.

Diego