[MPlayer-dev-eng] [PATCH] dvdnav - partial REVIEW

[James Courtier-Dutton]

Ötvös Attila wrote:
> Hi James Courtier-Dutton!
> 
> I modified the libdvdnav for mplayer:
> 
> dvdnav_get_audio_attr()
> dvdnav_get_spu_attr()
> These sherve to the mplayer can query the audio, spu language code and
> the audio type (stereo, 5.1, dolby digital, etc.).
> 
> Because of the still frames decoding error so get needed the repeat of 

What decoding error is this?

> these pgc-s this is way I created new functions:
> dvdnav_still_back() - repeat of the still frame cell (pgc)
> dvdnav_wait_back() - repeat of the cell (pgc)
> (but this functions don't reprocess dvd pre-commands)
> dvdnav_wait_still_clear() - end of the repeat
> dvdnav_is_still_cell() - Is it a still frame? (it doesn't probably need)
> dvdnav_button_auto_action() - enable/disable of the button auto action

It seems like a rather major work around to me. In xine we just store
the still frame on the output, and keep displaying it, instead of trying
to keep the stream full.

> 
> At the cell change event to processing the mplayer needs to deterimne 
> if the change is real or only repeat:
> dvdnav_get_pgc() - quering of the current pgc number
??? A cell is not the same as a pgc. (Program Chain)

> 
> New functions sice my last post to devel mail list:
> dvdnav_get_active_audio_stream()
> dvdnav_get_active_spu_stream()
> If menu spu id not default then mplayer query the spu id that's way mplayer 
> show correct spu.
Don't we already have this functionality. Maybe it is just implemented
differently. In any case, xine manages to switch to the correct active
stream at the right time.
A dvdnav_get_active_audio_stream() would surely not be accurate enough
time wise.

> 
> Best regards!
> Attila


James