[MPlayer-dev-eng] [PATCH] more AMD64 swscaler fixes

Michael Niedermayer michaelni at gmx.at
Sun May 28 21:09:15 CEST 2006


Hi

On Sun, May 28, 2006 at 02:31:39PM +0200, Reimar Döffinger wrote:
> Hi,
> On Sun, May 28, 2006 at 01:08:20PM +0200, Michael Niedermayer wrote:
> > On Sun, May 28, 2006 at 12:28:42PM +0200, Reimar Döffinger wrote:
> > > for AMD64 some variables passed via "m" constrained are 32bit values
> > > whereas they need to be 64 bit values, because otherwise the comparison
> > > that checks for e.g. end of a picture line will never come true -
> > > causing a segfault sooner or later.
> > > Attached patch fixes problems for me so far by replacing some ints by
> > > longs.
> > 
> > the changes to xInc_mask are rejected, this variable should be uint16_t
> 
> After reading the code, obviously. Thanks to little-endian it does not
> matter though *g*
> So, would you prefer the attached patch that changes xInc_mask to
> uin16_t, a seperate patch that changes xInc_mask or should xInc_mask
> just be left as it is now?

i dont care, either is fine 

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is



More information about the MPlayer-dev-eng mailing list