[MPlayer-dev-eng] [PATCH] Filename double-conversion

[Rich Felker]

On Wed, Nov 15, 2006 at 06:34:46PM +0100, Bernd Ernesti wrote:
> On Sun, Nov 12, 2006 at 11:43:21AM +0100, Reimar Döffinger wrote:
> > Hello,
> > On Sun, Nov 12, 2006 at 12:56:00PM +0800, Zuxy Meng wrote:
> > > Reimar & Rich, still no comments for the modified version?
> > 
> > Don't see any problems with it, though it seems not important to me
> > either.
> > If someone has some spare time, test and feel free to apply.
> 
> It doesn't compile on NetBSD:
> 
> mp_msg.c: In function `filename_recode':
> mp_msg.c:47: error: `MAX_PATH' undeclared (first use in this function)
> mp_msg.c:47: error: (Each undeclared identifier is reported only once
> mp_msg.c:47: error: for each function it appears in.)
> mp_msg.c: In function `mp_msg':
> mp_msg.c:126: warning: passing arg 2 of `iconv' from incompatible pointer type
> mp_msg.c: In function `filename_recode':
> mp_msg.c:47: error: storage size of `recoded_filename' isn't known
> 
> It seems that MAX_PATH is a windows thing.

yes.

> I changed it to PATH_MAX and included sys/param.h and now it compiled.
> Where I see no runtime difference when I play a file with a japanese
> filename.

sys/param.h is definitely the WRONG file and should not be used. the
standard place for this is <limits.h> and yes PATH_MAX is the right
#define to use.

rich