[MPlayer-dev-eng] [PATCH] warn about fontconfig beta versions.

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Oct 8 11:58:58 CEST 2006


Hello,
since SuSE has once again had the habit of shipping with broken beta
versions (see http://bugzilla.mplayerhq.hu/show_bug.cgi?id=588 ),
attached patch avoids the crash and warns that you are on your own when
using beta versions of fontconfig.

Greetings,
Reimar Döffinger
-------------- next part --------------
Index: libass/ass_fontconfig.c
===================================================================
--- libass/ass_fontconfig.c	(revision 20101)
+++ libass/ass_fontconfig.c	(working copy)
@@ -175,8 +175,12 @@
 	if (FcDirCacheValid((const FcChar8 *)dir) == FcFalse)
 	{
 		mp_msg(MSGT_GLOBAL, MSGL_INFO, "[ass] Updating font cache\n");
+		if (FcGetVersion() >= 20390 && FcGetVersion() < 20400)
+			mp_msg(MSGT_GLOBAL, MSGL_WARN,
+				"[ass] beta versions of fontconfig are not supported\n"
+				"      update before reporting any bugs\n");
 		// FontConfig >= 2.4.0 updates cache automatically in FcConfigAppFontAddDir()
-		if (FcGetVersion() < 20400) {
+		if (FcGetVersion() < 20390) {
 			FcFontSet* fcs;
 			FcStrSet* fss;
 			fcs = FcFontSetCreate();


More information about the MPlayer-dev-eng mailing list