[MPlayer-dev-eng] [PATCH] , escaping with \, support

[Michael Niedermayer]

Hi

On Tue, Oct 17, 2006 at 05:37:21PM +0200, Oded Shimon wrote:
> On Tue, Oct 17, 2006 at 04:54:04PM +0200, Michael Niedermayer wrote:
> > Hi
> > 
> > On Tue, Oct 17, 2006 at 04:41:29PM +0200, Diego Biurrun wrote:
> > > On Mon, Oct 16, 2006 at 05:34:52PM +0200, Michael Niedermayer wrote:
> > > > 
> > > > attached patch makes it possible to pass , to filters like
> > > > -vf filter1=a\,b:c,filter2
> > > 
> > > I'd say commit.  
> > 
> > i will in 24h or so if there are no objections
> > 
> > 
> > > I suppose this is for your new geq filter, right?
> > 
> > yes, alternatively i could also convert some unused char to ',' in the filter
> 
> I think filters should intentionally avoid using ',' as param seperators 
> as much as possible. this escaping is nice, but it should only be needed 
> in very rare situations such as giving a filename with a ',' in it, and 
> not as an actual necessity for a filter param...

its not the filter but rather lavc/eval.c which needs the ,
you dont really suggest that i change eval.c because mplayer has difficulty
with it? what if another player dislikes ^ or - or ( ? the parameters for
geq look obfuscated enough, no need to use unintuitive symbols IMHO

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is