[MPlayer-dev-eng] [PATCH] double click to switch to full screen in GUI

[laurent wozniak]

Hello,

Reimar Döffinger wrote:
> Hello,
> since Diego keeps annoying me about reviewing this patch, but I am not
> at all motivated, here is the absolutely minimal version for
> implementing double clicks.
> It certainly has deficiencies, but it is something to build onto without
> needing too many prerequisite patches.
> I did not get any of those "key not bound messages btw, I think they
> nowadays only appear with -v.
>   
As you said, this is a minimal approach.
And I understand you can be not motivated by a patch.

But the problem with this approach is that we keep in the code all the 
bugs I've identified and corrected.
And they will probably remain for a while.
For example, would somebody care about making X11 and SDL vo drivers 
consistent for some mouse behavior later on ?

> Now I still have one problem with it: I think it will interact badly
> with windows vos, which get the doubleclick events from windows
> directly.
> How to fix that?
> A quick hack if this somewhat incomplete patch should be part of rc1
> would be to put it under
> #if !defined(__MINGW32__) && !defined(__CYGWIN__)
>   
I'm not sure it's a good idea to start hacking when introducing a new 
feature.

X11 and SDL are already not behaving the same way for the mouse handling.
Introducing incompatibilities with Windows and Mac vo drivers in a 
generic part is something that doesn't sound nice to me.
Especially introducing #if_something as a hack is something that is hard 
to remove when you don't know why it has been placed there at first.

Moreover building a new feature on top of a part which has already 
identified bugs will make correcting those bugs even more difficult.

I think we should wait,
maybe let pass this release,
and take time to discuss for a solution that sounds good to everyone.


NOTE: I'll be in a business trip starting from the 24 oct, for a week,
and I will probably not be able to reach this mailing list during this 
period.


Cheers,
Laurent