[MPlayer-dev-eng] [PATCH] make cache2.c readable

[Diego Biurrun]

On Mon, Sep 11, 2006 at 01:54:33AM +0300, Uoti Urpala wrote:
> On Sun, 2006-09-10 at 23:39 +0200, Diego Biurrun wrote:
> > On Sun, Sep 10, 2006 at 10:43:19PM +0300, Uoti Urpala wrote:
> > > I think his reaction was quite reasonable. And I think following the
> > > requirements strictly and completely literally like rejecting patches
> > > for containing one or two cosmetic changes IS onerous.
> > 
> > You're more than welcome to disregard such onerous requirements and
> > review/apply/reject patches yourself.  More reviewers are desperately
> > needed.  Are you up to the task?
> 
> Yes, there are no reviewers for all patches. However I think the main
> problem is that in many cases most people are not using/interested
> in/familiar with the relevant code. The number of patches is not so high
> that dealing with some cosmetic changes in each would cause significant
> extra work.

I disagree completely.  I happen to be one of the (very few) active
reviewers, so I'm not making this up.  Look at what Michael says and
does, you'll see that he agrees.

Dealing with stray cosmetics and similar issues that could easily be
avoided does cause significant extra work.  Significant because it causes
me frustration and wastes my time that I could better spend reviewing
the next patch.  Significant because the bottleneck is at the reviewing
side, not at the submitting side.  Significant because if the submitter
doesn't get this right, I start having very little confidence in the
overall quality of the patch.  Significant because it makes reviewing
less enjoyable and may cause premature burnout.

If a patch submitter cannot be bothered to make things easy and
comfortable for me then I cannot be bothered to clean up behind the
submitter.

I'll ask my question again: More reviewers are desperately needed.  Are
you up to the task?

Diego