[MPlayer-dev-eng] Re: Fixing VideoCD playback in NetBSD

[Sergey Svishchev]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, Sep 10, 2006 at 11:25:14PM +0200, mplayer-dev-eng-request at mplayerhq.hu wrote:

>> NetBSD-specific code (stream/vcd_read_nbsd.h) has problems:
>>
>> a) Sector address conversion routines do not take into account
>> 150-sector offset (MSF address 0:0.0 is LBA -150); thus, wrong locations
>> on disc are read.  Usual failure mode: the disc will be played without
>> video; surprisingly, some discs will still play correctly.
>>
>> b) The "error" field of struct scsireq is unused by NetBSD kernel and
>> may contain random data.
>>
>> Please review these patches.  I've applied them to 1.0pre8 and verified
>> that troublesome VCDs now play OK on my NetBSD/i386 3.0.1 machine.
>
>Could you check how SVN version of MPlayer behaves? Does it still need
>this patch a all?
>
>Guillaume

dev-SVN-r19813-3.3.3 still needs this patch.

- -- 
Sergey Svishchev
-----BEGIN PGP SIGNATURE-----
Comment: ''

iD8DBQFFBwmM3P+wmuUns7URAtonAKCcye501iA6fFWbkTvQPLrumhe7jACfadDa
+TzmRDRJkWf2fEsW5pxUwcE=
=3FJ6
-----END PGP SIGNATURE-----