[MPlayer-dev-eng] [PATCH] further dvr-ms playback improvements

[Nico Sabbi]

Uoti Urpala wrote:

>On Mon, 2006-09-18 at 23:14 -0500, John Donaghy wrote:
>  
>
>>So it could be the case that the frametime can obtained accurately
>>using this new known GUID when it is present, and when it isnt present
>>then the 'average frame time' as obtained by my patch will suffice.
>>But I dont know without more samples plus I need to write some more
>>code to extract the frametime value from this HD sample I have.
>>
>>So I'm not sure what should be done here. Assuming the patch is ok, is
>>it still acceptable to use it given the above?  Or do we need more PAL
>>and HDTV samples and if so, from where? I'm guessing we need more
>>samples but please let me know.
>>    
>>
>
>The patch way the patch works now seems mostly OK, though I did not read
>it carefully. However you should generally use doubles, not floats, for
>pts values. Floats don't have enough precision for long files/streams.
>Many demuxers still use floats but that's because of historical reasons
>and they should be changed.
>  
>

shouldn't this change be done consistently on all demuxers?

>I'm not familiar with asf and so can't really comment on the
>format-specific questions.
>  
>

neither I, but the patch is clean and an improvement over the current code,
so if there are no objectsions I'll commit it tomorrow