[MPlayer-dev-eng] Re: vf_yadif.c: fix for (probably) older binutils

Tomas Janousek tomi at nomi.cz
Sun Sep 24 22:48:30 CEST 2006


Michael Niedermayer napsal(a):
> its ugly, id like to at least see the error message as gives and id like

The error message is:
vf_yadif.s:131: Error: bad expression
vf_yadif.s:131: Error: junk `1-1' after expression

The line is:
movq -1-1(%ebx,%edx), %mm2

> to have the patch author confirm that mplayer and yadif work correctly
> except this issue, there are plenty of -XYZ(something) in our code so
> it seems odd that as would fail with -1-1 but work with 0-1-1 and -1

I didn't see any artifacts and I can confirm that the generated code, 
when disassembled, is alright.

-- 
.---------    Tomáš Janoušek   a.k.a. Liskni_si    ---------.
: NOMI team, developer, http://tomi.nomi.cz/   tomi at nomi.cz :
' JID:liskni_si at jabber.cz, ICQ#161807083, tel:+420608876277 '




More information about the MPlayer-dev-eng mailing list