[MPlayer-dev-eng] [PATCH] add path support to glob-win32

[Reimar Döffinger]

Hello,
On Fri, Apr 06, 2007 at 01:49:06PM +0200, lode leroy wrote:
> This patch adds path support to the win32 implementation of glob.
> The current implementation only supports globbing in the current directory,
> so now it is possible to do
> 
> mencoder mf://C:/temp/*.bmp -o test.avi
> 
> whereas before this patch, one would have to do
> 
> OLDPWD=%PWD% & cd C:/temp & mencoder mf://*.bmp -o %OLDPWD%/test.avi & cd 
> OLDPWD

You are using strcpy and strcat on a fixed-size, on-stack buffer without
any checks. Even if this function is currently only used on
user-supplied data that is not acceptable.

Greetings,
Reimar Döffinger