[MPlayer-dev-eng] Re: [PATCH] af_ambisonic

Diego Biurrun diego at biurrun.de
Thu Apr 19 11:12:54 CEST 2007


On Wed, Apr 18, 2007 at 08:50:00PM -0400, Rich Felker wrote:
> On Wed, Apr 18, 2007 at 03:24:37PM +0200, Alex Beregszaszi wrote:
> > 
> > > >> +#if defined(_WIN32) && !defined (__CYGWIN__)
> > > >> +static char* strsep(char** haystack, char *needle)
> > > > what does this do?
> > > 
> > > It was actually a surprise to see there is no strsep(3) in mingw, so I
> > > reimplemented it.
> > 
> > In the case you can't live without it, the proper place is at osdep/ for
> > the strsep implementation. And don't forget adding configure checks.
> 
> This function is sufficiently trivial that just always rolling our own
> is better than slowing down configure with checks.

There already is a strsep implementation in osdep/.

Diego



More information about the MPlayer-dev-eng mailing list