[MPlayer-dev-eng] [PATCH] ddvnav+internal dvdread

[Diego Biurrun]

On Sat, Apr 28, 2007 at 02:48:45PM +0200, Nico Sabbi wrote:
> Diego Biurrun wrote:
> > On Sat, Apr 28, 2007 at 02:10:03PM +0200, Nico Sabbi wrote:
> > 
> >>If you install my fork of dvdnav configured to use an external dvdread,
> >>with this patch applied mplayer can use dvdnav and mplayer's dvdread
> >>(unless you pass --disable-dvdread-internal, in which case the system-wide
> >>dvdread will be used).
> > 
> > Why don't we drop support for the old libdvdnav versions?  AFAICT it
> > does not work anyway, so we should just require our forked version and
> > get rid of all these hacks.
> 
> because of 2+1 reasons it's not yet always feasible:
> - this particular configuration can be enabled only with the
>    new build system, that doesn't work on some platforms (e.g. osx);
>    the build system desperately needs an expert maintainer, that I'm 
>    not.

What's the problem?  There is no (good) dvdnav support with MPlayer ATM,
not on OS X and not on Linux.  I don't see a regression here...

>    Any volunteer ? :-))))

I can have a look at some point in the future.

> - by development policy libdvdnav must be backwards compatible,
>    so removing dvdread tout-court is out of question

Why?  You just took over, make those big changes!

> - it's still possible to have 2 different versions of dvdnav
>    (one backwards compatible for vlc/xine/whatever and another one
>    without dvdread for us), but I doubt that users want to have
>    2 different versions of the library

Judging from what I heard xine is interested in using the fork at some
point, this issue should be resolved at some point...

Diego