[MPlayer-dev-eng] [PATCH] fix for v4l1 driver

Vladimir Voroshilov voroshil at gmail.com
Sun Apr 29 02:08:11 CEST 2007


2007/4/28, Trent Piepho <xyzzy at speakeasy.org>:

>@@ -798,6 +770,53 @@
>     if (ioctl(priv->video_fd, VIDIOCSPICT, &priv->picture) == -1)
>     {
> 	mp_msg(MSGT_TV, MSGL_ERR, "ioctl set picture failed: %s\n", strerror(errno));
>+	mp_msg(MSGT_TV, MSGL_ERR, "The 'outfmt' of '%s' is likely not
supported by your card\n",
>+	       vo_format_name(priv->format));
>+	return 0;

Why don't you change existing message?
Other parts looks ok for for me at quick-look.

In another cosmetics patch you also change comment in disabled block of
code.
Can i know the reason for it ?

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
ICQ: 95587719



More information about the MPlayer-dev-eng mailing list