[MPlayer-dev-eng] PVR Channel Navigation

[Nico Sabbi]

Sven Gothel wrote:
> Again, thx to Reimar for the review.
> 
> For now, I think this one is a good result
> and in balance of 'our styles'.
> 
> Now, I believe it's up to Benjamin to bring this code in !?
> 
> Cheers, Sven
> 
> +++
> 


without reading the code I found the following

>  }
>  
> +

cosmetics

>  static int
>  v4l2_list_capabilities (struct pvr_t *pvr)
>  {
> @@ -916,13 +1551,14 @@
>                "%s read (%d) bytes\n", LOG_LEVEL_PVR, pos);
>      }
>    }
> -		
> +        

cosmetics

>    if (!pos)
>      mp_msg (MSGT_OPEN, MSGL_ERR, "%s read %d bytes\n", LOG_LEVEL_PVR, pos);
>  
>    return pos;
>  }
>  
> +
>  static int
>  pvr_stream_open (stream_t *stream, int mode, void *opts, int *file_format)
>  {

cosmetics
>  
> +  if (pvr->freq>0)
> +  {
> +      return set_v4l2_freq (pvr) ;
> +  }
>    return 0;
>  }
>  
> +

cosmetics

>  static int
>  v4l2_list_capabilities (struct pvr_t *pvr)
>  {
> @@ -916,13 +1551,14 @@
>                "%s read (%d) bytes\n", LOG_LEVEL_PVR, pos);
>      }
>    }
> -		
> +        

cosmetics

>    if (!pos)
>      mp_msg (MSGT_OPEN, MSGL_ERR, "%s read %d bytes\n", LOG_LEVEL_PVR, pos);
>  
>    return pos;
>  }
>  
> +
>  static int
>  pvr_stream_open (stream_t *stream, int mode, void *opts, int *file_format)
>  {
> @@ -935,6 +1571,15 @@


cosmetics

Not exactly showstoppers, but disturbing anyway.
Are you sure your code can't be shrinked? The equivalent code
in dvb:// is probably shorter than the amount code you added