[MPlayer-dev-eng] Better handling of low FPS and still images

Rich Felker dalias at aerifal.cx
Fri Aug 24 03:36:38 CEST 2007


On Thu, Aug 23, 2007 at 07:48:34PM +0200, Alban Bedel wrote:
> On Wed, 22 Aug 2007 16:40:52 +0300
> Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
> 
> > [0001-Use-bitfield-instead-of-manual-bit-fiddling-in-input.patch
> > text/x-patch (5.8KB)] Use bitfield instead of manual bit fiddling in
> > input.c
> 
> I don't have much time but I will try to review all the patches in the
> next days. But for a start this, as pure useless cosmetic, is definitly
> rejected unless you have a very good reason (and "style" is not one).

I'm against ever using bitfields, for technical reasons. It's
impossible to copy, compare, or manipulate multiple bits at once
because each one acts like a separate variable. As far as I'm
concerned, putting bitfields in the C language was a very stupid
mistake in the first place.

Rich



More information about the MPlayer-dev-eng mailing list