[MPlayer-dev-eng] Better handling of low FPS and still images

[Reimar Döffinger]

Hello,
On Fri, Aug 24, 2007 at 05:17:44AM +0300, Uoti Urpala wrote:
> On Thu, 2007-08-23 at 19:48 +0200, Alban Bedel wrote:
> > On Wed, 22 Aug 2007 16:40:52 +0300
> > Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
> > 
> > > [0001-Use-bitfield-instead-of-manual-bit-fiddling-in-input.patch
> > > text/x-patch (5.8KB)] Use bitfield instead of manual bit fiddling in
> > > input.c
> > 
> > I don't have much time but I will try to review all the patches in the
> > next days.
> 
> I'll probably apply them within a day or two. Of course any bugs you
> find can still be fixed after that.

Excluding the last one I hope?
Also, I had a quick look and it looks mostly okay to me (except for the
change to bitfields, I can see quite a few disadvantages in them, but I
haven't checked if they apply to this case), but given the
potential to completely break windows and other ports, two days is a
much too short time unless you get someone to test.
Lastly, in the fallback case when HAVE_POSIX_SELECT is not available, it
might not be a good idea to sleep the whole time, it should wake up at
least every 100 ms and re-check if a command is available (please
disregard if "time" can never be > 100, but even then a comment saying
this would be nice IMO).

Greetings,
Reimar Döffinger