[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

[Ulion]

2007/12/12, Ulion <ulion2002 at gmail.com>:
> 2007/12/12, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Hello,
> > > If there's no objection, I will apply this patch in 2 days.
> >
> > I _strongly_ object to having the MinGW version enabled by default,
> > since even Microsoft obviously does not know how to do escaping
> > correctly I do not have any confidence whatsoever that this code is
> > correct.
> > Actually am somewhat opposed to having this functionality for MinGW
> > at all unless we find a way to _guarantee_ the escaping does not
> > introduce exploitable bugs.
>
> I insist commit the mingw version and set it default disabled on mingw
> when compiling.
> That's all I can do for mingw users (probably most of win32 users), at
> least they will have choice to use this 'risky' code or some illegal
> licensed patch (which could be risky too) to do same thing. Or they
> should stop to use their risky system with risky applications. This is
> the best safe code I can do for them for now, if anybody can do it
> better, just do it, or you always has an unexisted dreamful 'safe'
> version code just like fresh air.

MingW part code update: work properly with multi-byte system codepage,
prevent miss-escape any bytes of multi-byte charactors. This update
change a lot, so I will wait 3 days for any objections.

-- 
Ulion
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: unrar_exec17.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071213/62a1307d/attachment.txt>