[MPlayer-dev-eng] [PATCH] Fix memleak in stream_dvb.c (and libmenu patch)

[Andrew Calkin]

2007/12/15, Nico Sabbi <Nicola.Sabbi at poste.it>:
> Il Saturday 15 December 2007 13:15:46 Andrew Calkin ha scritto:
> > 2007/12/15, Andrew Calkin <calkina at geexbox.org>:
> > > 2007/12/15, Nico Sabbi <Nicola.Sabbi at poste.it>:
> >
> > Hi Nico,
> >
> > Don't bother replying, Ulion provided a good explanation of the
> > error I made.
> >
> > I look forward to your patch.
> >
> > //Andrew
>
> applied dvb_free_config() after having reformatted it
> and removed some useless check. You also forgot
> to call it from withing libmenu/menu_dvbin.c.
>
> Of course every new open of stream_dvb.c will have
> to re-parse the config files, but not when switching
> channels, for example:
>
> $ mplayer dvb://LA72   file.avi   dvb://MTV
> will parse the files twice, but it's much cleaner
> (and not so commonly used to worry for the slowdown)

I suspected there would be bugs in my code- i wrote it on a friday
afternoon at work in about 10mins, just before running off to a sports
game. I did not have time to test, and only checked that it compiled
first. But, since only patches submitted seem to get a response, and i
knew it would get a proper review, it would be faster than me digging
out my dvb h/w which i have no time to use nowadays anyway. If you had
wanted I could have rewritten the patches based on your suggestions,
until they were acceptable.

//Andrew