[MPlayer-dev-eng] [PATCH] fix a few warnings

Rich Felker dalias at aerifal.cx
Tue Feb 6 18:56:00 CET 2007


On Tue, Feb 06, 2007 at 02:34:44PM +0100, Reimar Doeffinger wrote:
> Hello,
> On Tue, Feb 06, 2007 at 12:50:16AM +0100, Dominik 'Rathann' Mierzejewski wrote:
> > -              mp_msg(MSGT_DEMUX, MSGL_ERR, "Invalid cmvd atom size %d\n", moov_sz);
> > +              mp_msg(MSGT_DEMUX, MSGL_ERR, "Invalid cmvd atom size %ld\n", moov_sz);
> 
> %ld is not the correct format string for size_t, there actually is no
> portable one for it AFAIK.

%zu is portable in the sense that it's C99. But broken systems don't
support it. Just cast to long and use %lu.

> I personally find that patch also a bit overkill for one warning, that
> in addition only appears on 64 bit architectures...

Also appears for me.

Rich



More information about the MPlayer-dev-eng mailing list