[MPlayer-dev-eng] [PATCH] Switch libavutil macros instead of defining our own

Roberto Togni rxt at rtogni.it
Sat Feb 24 20:58:38 CET 2007


On Sat, 24 Feb 2007 19:23:05 +0100
Michael Niedermayer <michaelni at gmx.at> wrote:

[...]
> > @@ -78,40 +73,40 @@
> >  static void rmff_dump_fileheader(rmff_fileheader_t *fileheader, char *buffer) {
> >  
> >    if (!fileheader) return;
> > -  fileheader->object_id=BE_32(&fileheader->object_id);
> > -  fileheader->size=BE_32(&fileheader->size);
> > -  fileheader->object_version=BE_16(&fileheader->object_version);
> > -  fileheader->file_version=BE_32(&fileheader->file_version);
> > -  fileheader->num_headers=BE_32(&fileheader->num_headers);
> > +  fileheader->object_id=AV_RB32(&fileheader->object_id);
> > +  fileheader->size=AV_RB32(&fileheader->size);
> > +  fileheader->object_version=AV_RB16(&fileheader->object_version);
> > +  fileheader->file_version=AV_RB32(&fileheader->file_version);
> > +  fileheader->num_headers=AV_RB32(&fileheader->num_headers);
> 
> as you already change it what about also vertically aligning it :)
> 

Please don't. It won't look any better and it will require more
cosmetics everytime something it's changed if you want to keep the
alignment.

Ciao,
 Roberto



More information about the MPlayer-dev-eng mailing list