[MPlayer-dev-eng] [PATCH] VFCTRL_PERIODIC_UPDATE

[Uoti Urpala]

On Thu, 2007-01-11 at 21:36 -0500, Jason Tackaberry wrote:
> Timing is controlled by the application.  The filter doesn't know it
> needs to update the overlay until the app controlling mplayer in slave
> mode issues the relevant slave command.
> 
> How about we create a small function in input/input.c that selects on
> the input fds.  This way any slave command (particularly one to control
> the overlay) would wake mplayer so it can call periodic_update().

If it's a slave command that triggers the timing then it sounds like the
slave input needs to be read and parsed, and that might cause new
problems since then you need to be able to somehow handle ALL slave
commands in any location that could sleep. Your previous patch did not
read slave input between the sleeps in main timing; would something
(what?) have triggered the filter, or was that another error in the
patch?

If you need to handle slave commands immediately then it's probably
better to exit the current timing loop when there's control input and go
around the main play loop to read+handle the input.